Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace authorImage with authorImageURL #314

Merged
merged 4 commits into from
May 7, 2018

Conversation

amyrlam
Copy link
Contributor

@amyrlam amyrlam commented Apr 18, 2018

  • ⬆️ Docusaurus

  • authorImage will be deprecated in Docusaurus

Included format updates generated by Docusaurus, re: format updates, check out https://github.com/facebook/react-native-website/pull/314/files?w=1 will address separately

Relates to: facebook/docusaurus#577 cc @yangshun

No visual change to author image in blog:
image

@yangshun
Copy link
Contributor

yangshun commented Apr 18, 2018 via email

@react-native-bot
Copy link

react-native-bot commented Apr 18, 2018

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

@amyrlam amyrlam changed the title Replace authorImage with authorImageURL [Do Not Merge] Replace authorImage with authorImageURL Apr 18, 2018
@amyrlam
Copy link
Contributor Author

amyrlam commented Apr 18, 2018

Ah gotcha, sorry about that. I added Do Not Merge and will update this PR when ready.

@yangshun
Copy link
Contributor

@amyrlam Docusaurus 1.0.12 has been released!

@react-native-bot
Copy link

react-native-bot commented Apr 18, 2018

Deploy preview for react-native ready!

Built with commit 963a62e

https://deploy-preview-314--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@amyrlam amyrlam changed the title [Do Not Merge] Replace authorImage with authorImageURL Replace authorImage with authorImageURL Apr 18, 2018
@amyrlam
Copy link
Contributor Author

amyrlam commented Apr 18, 2018

👋 Sorry for the confusion before, this is ready for review now.

@yangshun
Copy link
Contributor

yangshun commented Apr 19, 2018

The preview looks good to me! @hramos @charpeni mind taking a look?

@amyrlam
Copy link
Contributor Author

amyrlam commented Apr 24, 2018

Updated Docusaurus to latest 1.0.14

Copy link

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I am going to let @hramos approve and merge it in.

@hramos hramos self-assigned this Apr 25, 2018
authorImage will be deprecated in a future Docusaurus version
@hramos hramos merged commit b2dbd7b into facebook:master May 7, 2018
@hramos
Copy link
Contributor

hramos commented May 7, 2018

Thanks for your contribution!

@yangshun yangshun deleted the amy/update-docusaurus branch May 7, 2018 23:34
amyrlam added a commit to amyrlam/Docusaurus that referenced this pull request May 8, 2018
authorImage was replaced by authorImageURL in facebook#577

authorImage was removed in react-native-website in facebook/react-native-website#314
amyrlam added a commit to amyrlam/Docusaurus that referenced this pull request May 8, 2018
authorImage was replaced by authorImageURL in facebook#577

authorImage was removed from react-native-website in facebook/react-native-website#314 

authorImage was undocumented, so no docs changes
amyrlam added a commit to amyrlam/Docusaurus that referenced this pull request May 8, 2018
authorImage was replaced by authorImageURL in facebook#577

authorImage was removed from react-native-website in facebook/react-native-website#314 

authorImage was undocumented, so no docs changes
yangshun pushed a commit to facebook/docusaurus that referenced this pull request May 8, 2018
authorImage was replaced by authorImageURL in #577

authorImage was removed from react-native-website in facebook/react-native-website#314 

authorImage was undocumented, so no docs changes
amyrlam added a commit to amyrlam/react-native-website that referenced this pull request May 10, 2018
amyrlam added a commit to amyrlam/react-native-website that referenced this pull request May 10, 2018
charpeni pushed a commit that referenced this pull request May 11, 2018
risenforward pushed a commit to risenforward/proactive-web that referenced this pull request Jan 4, 2019
JackWillie added a commit to JackWillie/react-native-website that referenced this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants